Fix configure_subplots with tool manager #22743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`configure_subplots` requires a) an object from which it can get the `canvas` property, and b) somewhere it can store its handle for re-use. The pseudo-toolbar that is used for most `Tool` classes is temporary and does not provide the latter. However, tools inherit from `ToolBase` which contains a `canvas` property and they exist for the lifetime of the toolbar, so can be used instead. Fixes matplotlib#22088
timhoffm
approved these changes
Mar 31, 2022
oscargus
approved these changes
Mar 31, 2022
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Mar 31, 2022
1 task
oscargus
added a commit
that referenced
this pull request
Apr 1, 2022
…3.5.x Backport PR #22743: Fix configure_subplots with tool manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
configure_subplotsrequires a) an object from which it can get thecanvasproperty, and b) somewhere it can store its handle for re-use.The pseudo-toolbar that is used for most
Toolclasses is temporary anddoes not provide the latter. However, tools inherit from
ToolBasewhich contains a
canvasproperty and they exist for the lifetime ofthe toolbar, so can be used instead.
Fixes #22088
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).