Skip to content

Fix pickling of globally available, dynamically generated norm classes. #22815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2022
Merged

Fix pickling of globally available, dynamically generated norm classes. #22815

merged 1 commit into from
Apr 10, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 9, 2022

PR Summary

Closes #20755 (again), #22313 (comment)

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer anntzer added this to the v3.6.0 milestone Apr 9, 2022
@oscargus oscargus merged commit 2aa4b7d into matplotlib:main Apr 10, 2022
@anntzer anntzer deleted the normpickle branch April 10, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

[Bug]: make_norm_from_scale should create picklable classes even when used in-line.
3 participants
@anntzer @tacaswell @oscargus