Skip to content

Fix Tk error when updating toolbar checkbutton images #22841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2022
Merged

Fix Tk error when updating toolbar checkbutton images #22841

merged 1 commit into from
Apr 14, 2022

Conversation

daniilS
Copy link
Contributor

@daniilS daniilS commented Apr 13, 2022

PR Summary

Fixes #22836 introduced in #22163

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@daniilS daniilS mentioned this pull request Apr 13, 2022
Closed
@richardsheridan richardsheridan self-assigned this Apr 13, 2022
@tacaswell tacaswell added this to the v3.6.0 milestone Apr 13, 2022
tacaswell
tacaswell approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable, but someone who has a dark-themed desktop should manually test this before it gets merged!

richardsheridan
richardsheridan approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@richardsheridan richardsheridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually checked the dpi change error and the dark-mode behavior and it looks good to go

@QuLogic QuLogic merged commit 4e20f15 into matplotlib:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@richardsheridan richardsheridan richardsheridan approved these changes

Assignees

@richardsheridan richardsheridan

Labels
GUI: tk
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

[Bug]: TclError raised by _set_image_for_button() when _update_window_dpi() runs
5 participants
@daniilS @tacaswell @richardsheridan @QuLogic @oscargus