fix and test deprecated layout method toggling #22849
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a heads up that I cannot review anything properly for a week or so. Thanks! |
timhoffm
approved these changes
Apr 15, 2022
|
Is None the "null"-layout engine? It looks like there is also mention of the string "none" here: |
|
Any interest in doing this for 3.5.3 and saving #22452 for 3.6.0? |
|
Sorry, I missed this entirely until I saw it was closed! In the future, please err on the side of re-milestoning things back if you want them to be in a bug fix release. The reason #22452 picked up all of the extra complexity is that just setting it back to None could end up breaking the colorbars so I would still be wary of this fix. |
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Jan 10, 2023
Re-uses the tests from matplotlib#22849, but also tests that going _back_ on works as well. Fixes matplotlib#22847 Co-authored-by: richardsheridan <richard.sheridan@gmail.com>
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Jan 10, 2023
Re-uses the tests from matplotlib#22849, but also tests that going _back_ on works as well. Fixes matplotlib#22847 Co-authored-by: richardsheridan <richard.sheridan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #22847. Not sure if there are knock-on effects, looking forward to code review.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).