TST: Avoid floating point errors in asinh ticker #22854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This avoids the floating point issues with tests in the asinh tick locator by moving away from the 100 log10 cliff. This was failing with the new AVX instruction updates in numpy. The underlying issue here is that the floating point accuracy around 100 changes from one side to the other and the
floor()
call doesn't accept precision arguments. This is not what we are trying to test, so just move the test values away from that edge.Closes #22708
Showing the tests passing on my fork: https://github.com/greglucas/matplotlib/actions/runs/2177190522
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).