Skip to content

TST: Avoid floating point errors in asinh ticker #22854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

greglucas
Copy link
Contributor

PR Summary

This avoids the floating point issues with tests in the asinh tick locator by moving away from the 100 log10 cliff. This was failing with the new AVX instruction updates in numpy. The underlying issue here is that the floating point accuracy around 100 changes from one side to the other and the floor() call doesn't accept precision arguments. This is not what we are trying to test, so just move the test values away from that edge.

Closes #22708

Showing the tests passing on my fork: https://github.com/greglucas/matplotlib/actions/runs/2177190522

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

This avoids the floating point issues with tests in the asinh tick
locator by moving away from the 100 log10 cliff. This was failing with
the new AVX instruction updates in numpy.
@greglucas greglucas added this to the v3.6.0 milestone Apr 16, 2022
@oscargus oscargus merged commit 3f881ed into matplotlib:main Apr 16, 2022
@greglucas greglucas deleted the tst-asinh branch April 16, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TST] Upcoming dependency test failures
3 participants