Clarify logic for repl displayhook. #22906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Apr 26, 2022
timhoffm
reviewed
Apr 26, 2022
_IP_REGISTERED and _INSTALL_FIG_OBSERVER effectively encode a 3-state, so just store that as a single _REPL_DISPLAYHOOK variable. Also make post_execute a globally available (private) function, so that it doesn't need to be smuggled via _IP_REGISTERED to uninstall_repl_displayhook.
f1b3fa3 to
6c7cf65
Compare
timhoffm
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_IP_REGISTERED and _INSTALL_FIG_OBSERVER effectively encode a 3-state,
so just store that as a single _REPL_DISPLAYHOOK variable. Also make
post_execute a globally available (private) function, so that it doesn't
need to be smuggled via _IP_REGISTERED to uninstall_repl_displayhook.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).