Clarify docstring of [un]install_repl_displayhook() #22911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
anntzer
reviewed
Apr 27, 2022
lib/matplotlib/pyplot.py
Outdated
| @@ -153,7 +156,7 @@ def post_execute(): | |||
|
|
|||
| def uninstall_repl_displayhook(): | |||
| """ | |||
| Uninstall the Matplotlib display hook. | |||
| Disconnect from the display hook of the current shell. | |||
|
|
|||
| .. warning:: | |||
There was a problem hiding this comment.
While you are here, you can remove this warning entirely, I think: this system does not actually interact with sys.displayhook ever since #4506.
dc0ca60 to
618ecc9
Compare
Still not clear to me: Does this have to be a public function? When would a user call it explicitly?
618ecc9 to
83701e9
Compare
anntzer
approved these changes
Apr 27, 2022
|
I think it's worth letting @tacaswell have a look before merging, as he's probably the most knowledgeable on this topic. |
|
It is fun that we have both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still not clear to me: Does this have to be a public function? When
would a user call it explicitly?