Skip to content

Fix example "Scale invariant angle label" #22958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix example "Scale invariant angle label" #22958

wants to merge 1 commit into from

Conversation

kkoutris
Copy link

@kkoutris kkoutris commented May 2, 2022

PR Summary

Fix f documentation AngleLabel example where the text wasn't inside the arc.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@kkoutris
Copy link
Author

kkoutris commented May 2, 2022

Closes #22392

github-actions[bot]
github-actions bot reviewed May 2, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@QuLogic
Copy link
Member

QuLogic commented May 2, 2022

Please target main, not the doc branch.

@oscargus
Copy link
Member

oscargus commented May 2, 2022

And please create your own branch. Something like git checkout -b mynewbranchname should do. The easiest right now may be to simply start from the main branch, create a new branch as above, introduce the changes there, commit, push and create a new PR.

(The errors relate to too long lines, so please break them accordingly.)

@QuLogic QuLogic deleted the branch matplotlib:v3.5.1-doc-to-delete May 3, 2022 04:08
@QuLogic QuLogic closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkoutris @QuLogic @oscargus