Skip to content

CI: bump test limit from tkagg on osx #22987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022

Conversation

tacaswell
Copy link
Member

Extension of #22959.

PR Summary

We are still seeing intermittent failures on OSX with the memory leak check on tkagg.

This is taking the gentler approach and increasing the limits again, however there may may be a case for skipping these tests until we understand:

  1. the remaining source of the leak in tk (and if this is even a real leak vs legitimately still held objects)
  2. we understand the source of the variation

PR Checklis

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

@tacaswell tacaswell added this to the v3.5.3 milestone May 6, 2022
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for now, I suppose.

@timhoffm timhoffm merged commit 357276b into matplotlib:main May 6, 2022
@tacaswell tacaswell deleted the ci_bump_osxtkagg_limit branch May 6, 2022 22:48
@tacaswell
Copy link
Member Author

meeseeksdev backport to v3.5.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request May 6, 2022
QuLogic added a commit that referenced this pull request Jul 23, 2022
…987-on-v3.5.x

Backport PR #22987 on branch v3.5.x (CI: bump test limit from tkagg on osx)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants