Additional details on VS install on installation page #23000
Conversation
The addition to this page informs Windows users building their development environment that they will need to ensure specific Visual Studio workloads are installed.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thank you @23ccozad ! This reads correctly to me, but I do not have a windows machine (or develop on windows regularly) so lack the expertise to actually review this.... |
There was a problem hiding this comment.
Looks great!
I did a clean install on a Windows machine. I attempted to build without the packages that you specified and ran into the same errors. I installed the packages and it was able to build.
The next step to getting this merged is waiting for 2 maintainers with write access to approve this PR. For what it's worth, I approve!
|
There is a discrepancy in the naming of "C++ CMake tools for Windows" in previous version of Visual Studio (such as Visual Studio 2017). However, if someone is going to install Visual Studio for the first time, they are likely downloading the latest version, so I don't think it is worth changing. I think any change or addition would make it confusing. |
|
Thanks @23ccozad for the PR and @andrew-fennell for checking and approving. As documentation changes can be merged with a single approval (on the "better than before" premise) and the additional approval, I'll merge. Congratulations on your first PR to Matplotlib! Hope to see you around! |
|
@meeseeksdev backport to v3.5.x |
PR Summary
Originally from an issue we resolved in Gitter as I was building from source. The docs currently don't specify which parts of Visual Studio that Windows users need when installing matplotlib from source. This PR adds this information to the docs, and also provides a link to a page from which VS can be downloaded.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).