Skip to content

[ENH] : Provide axis('equal') for Axes3D (replace PR #22705) #23017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ENH] : Provide axis('equal') for Axes3D (replace PR #22705) #23017

wants to merge 1 commit into from

Conversation

patquem
Copy link
Contributor

@patquem patquem commented May 9, 2022

PR Summary

Closes #22570
Make axis('equal') available

@oscargus
Replace PR #22705 with a separate dedicated branch

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus added this to the v3.6.0 milestone May 9, 2022
@scottshambaugh
Copy link
Contributor

scottshambaugh commented May 17, 2022 •
edited
Loading

A 'what's new' entry would be great for this one (I'm pretty excited for all the 3.6.0 mplot3d features coming in)

@jklymak jklymak marked this pull request as draft May 24, 2022 11:04
@jklymak
Copy link
Member

jklymak commented May 24, 2022

@patquem can you add a What New Note (doc/users/next-whats-new) and move back out of draft?

@scottshambaugh
Copy link
Contributor

scottshambaugh commented Jul 8, 2022 •
edited
Loading

If @patquem is not reachable I'd say we merge without the what's new note and I can make a separate PR to add that in. Would hate to miss 3.6 on this great feature just because of that.

@QuLogic
Copy link
Member

QuLogic commented Jul 9, 2022

This needs a rebase to fix conflicts as well.

@jklymak
Copy link
Member

jklymak commented Jul 9, 2022

@scottshambaugh maybe you could open a new PR based on this one, rebased and with the note? If you keep the authored-by comment in the commit message the original author will still get credit.

@scottshambaugh scottshambaugh mentioned this pull request Jul 9, 2022
Merged
5 tasks
@patquem
Copy link
Contributor Author

patquem commented Jul 11, 2022

Hello everyone,
Sorry for not havin answered sooner.
Regarding the current PR I was faced to so many problems while I working on it that I didn't want (couldn't) spend more time on 'documentation'.
I see you are still working on the 3D aspect_equal to improve it .. and that's great !! :)
(next time, I will try to do things to the end)
Patrick

@scottshambaugh
Copy link
Contributor

Thank you for your work on it!

tacaswell added a commit that referenced this pull request Aug 3, 2022
@tacaswell
Merge pull request #23409 from scottshambaugh/aspect_equal_3d
437158c 
ENH: Provide axis('equal') for Axes3D

replaces PR #23017
@scottshambaugh
Copy link
Contributor

This can close with the merge of #23409

@QuLogic QuLogic closed this Aug 3, 2022
@tacaswell
Copy link
Member

Thank you for your work on this @patquem !

@liuzhenqi77 liuzhenqi77 mentioned this pull request Nov 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
status: needs documentation status: needs rebase topic: mplot3d
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

[ENH]: Provide axis('equal') for Axes3D.
6 participants
@patquem @scottshambaugh @jklymak @QuLogic @tacaswell @oscargus