Skip to content

Fix example for "Scale invariant angle label" #23027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix example for "Scale invariant angle label" #23027

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c407798
Fix example "Scale invariant angle label"
kkoutris May 2, 2022
7dafd2d
Fix example "Scale invariant angle label"
kkoutris May 9, 2022
d57af62
Fix code to be on par with flake
kkoutris May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions examples/text_labels_and_annotations/angle_annotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def update_text(self):
r = s / 2
if self.textposition == "inside":
r = s / np.interp(angle_span, [60, 90, 135, 180],
[3.3, 3.5, 3.8, 4])
[10, 3.5, 11.4, 4])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right approach to fix the issue. This is moving the text, but the issue is really about the scaling of the angle markings.

self.text.xy = c + r * np.array([np.cos(angle), np.sin(angle)])
if self.textposition == "outside":
def R90(a, r, w, h):
Expand Down Expand Up @@ -237,10 +237,14 @@ def R(a, r, w, h):
line2, = ax.plot(*zip(*p2))
point, = ax.plot(*center, marker="o")

am1 = AngleAnnotation(center, p1[1], p2[1], ax=ax, size=75, text=r"$\alpha$")
am2 = AngleAnnotation(center, p2[1], p1[0], ax=ax, size=35, text=r"$\beta$")
am3 = AngleAnnotation(center, p1[0], p2[0], ax=ax, size=75, text=r"$\gamma$")
am4 = AngleAnnotation(center, p2[0], p1[1], ax=ax, size=35, text=r"$\theta$")
am1 = AngleAnnotation(center, p1[1], p2[1], ax=ax, size=75,
textposition="inside", text=r"$\alpha$")
am2 = AngleAnnotation(center, p2[1], p1[0], ax=ax, size=35,
textposition="inside", text=r"$\beta$")
am3 = AngleAnnotation(center, p1[0], p2[0], ax=ax, size=75,
textposition="inside", text=r"$\gamma$")
am4 = AngleAnnotation(center, p2[0], p1[1], ax=ax, size=35,
textposition="inside", text=r"$\theta$")
Comment on lines +240 to +247
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

textposition="inside" is the default for the AngleAnnotation class.

This can be found here:

matplotlib/examples/text_labels_and_annotations/angle_annotation.py

Line 71 in 046c5b2

text="", textposition="inside", text_kw=None, **kwargs):



# Showcase some styling options for the angle arc, as well as the text.
Expand Down