TST: forgive more failures on pyside2 / pyside6 cross imports #23069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
May 18, 2022
anntzer
reviewed
May 18, 2022
| @@ -359,6 +359,10 @@ def test_cross_Qt_imports(): | |||
| # are doing something that we do not expect to work | |||
| if ex.returncode == -11: | |||
| continue | |||
| # We got the abort signal which is likely because the Qt5 / | |||
| # Qt6 cross import is unhappy, carry on. | |||
| elif ex.returncode == -6: | |||
There was a problem hiding this comment.
perhaps == -signal.SIGABRT here (and likewise -signal.SIGSEGV just above)?
|
Thanks, tested locally and confirmed it obviously work. ;) |
|
I don't know why Ubuntu started failing now. |
I looked at this yesterday and it looks like issues counting fonts (?!) The test does something funny where it does a |
|
I noticed it was passing on another PR, so I restarted them and it's all magically working again. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 19, 2022
… pyside6 cross imports
QuLogic
added a commit
that referenced
this pull request
May 19, 2022
…069-on-v3.5.x Backport PR #23069 on branch v3.5.x (TST: forgive more failures on pyside2 / pyside6 cross imports)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #23004
This is testing that we warn something is a bad idea and failing because it is indeed a bad idea.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).