MNT: Removing 3.4 deprecations #23093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
May 22, 2022
| Get/set window title methods have been removed from the canvas | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Use the corresponding methods on the FigureManager instead. |
There was a problem hiding this comment.
Maybe mention also that one can use the native methods of a GUI framework if cross-backend compatibility is not needed.
| Axes creation no longer accepts positional arguments other than figure and rect | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Pass in the explicit keyword arguments desired when creating the axes. |
There was a problem hiding this comment.
Wording: explicit keyword arguments does not speak to me. Better: "Pass all other parameters as keyword arguments."
| ``imread()`` no longer accepts URLs | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| These should be opened and passed directly to Pillow now. |
There was a problem hiding this comment.
👍 I updated all of the change log suggestions. I went back and took the wording from the 3.4 deprecations (not sure why I didn't do that in the first place 😄)
This is the removal after the deprecation period.
This follows the deprecation period.
This follows the deprecation period.
This follows the deprecation period.
This follows the deprecation period.
This follows the deprecation period.
This follows the deprecation period.
There are no tests that need network access, so remove the marker.
This follows the deprecation period.
jklymak
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This removes more 3.4 deprecations. I've put each removal into a separate commit, this seemed easier than opening a bunch of PRs, but I can do that if it would be easier to review.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).