Reuse subprocess_run_helper in test_pylab_integration. #23106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
May 23, 2022
It's basically here for that purpose...
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
7 tasks
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
May 23, 2022
MNT: Reuse subprocess_run_helper in test_pylab_integration. (cherry picked from commit 51624b6)
jklymak
pushed a commit
that referenced
this pull request
Jun 2, 2022
* Backport PR #23057: FIX: ensure switching the backend installs repl hook Merge pull request #23057 from tacaswell/fix_pylab (cherry picked from commit b31c5ae) * Merge pull request #23106 from anntzer/tpi MNT: Reuse subprocess_run_helper in test_pylab_integration. (cherry picked from commit 51624b6) * TST: Adjust to state tracking on 3.5.x branch The implementation of tracking if the repl displayhook is installed changed on main. Adjust the backported test to work with the old way. Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's basically here for that purpose...
Followup to #23057.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).