Skip to content

Backport PR #23057 and #23106 #23113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2022
Merged

Backport PR #23057 and #23106 #23113

merged 3 commits into from
Jun 2, 2022

Conversation

tacaswell
Copy link
Member

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

anntzer and others added 2 commits May 23, 2022 18:08
@anntzer @tacaswell
Backport PR matplotlib#23057: FIX: ensure switching the backend insta…
d2da83f 
…lls repl hook

Merge pull request matplotlib#23057 from tacaswell/fix_pylab

(cherry picked from commit b31c5ae)
@tacaswell
Merge pull request matplotlib#23106 from anntzer/tpi
829b699 
MNT: Reuse subprocess_run_helper in test_pylab_integration.
(cherry picked from commit 51624b6)
@tacaswell tacaswell added this to the v3.5.3 milestone May 23, 2022
QuLogic
QuLogic previously approved these changes May 24, 2022
View reviewed changes
@QuLogic QuLogic dismissed their stale review May 24, 2022 21:58

Seems to have broken tests somehow.

@QuLogic
Copy link
Member

QuLogic commented May 24, 2022

Broke tests:

stdout = "Using matplotlib backend: QtAgg\n\x1b[0;31m--------------------------------------------------------------------------....\x1b[39mIPYTHON\n\n\x1b[0;31mAttributeError\x1b[0m: module 'matplotlib.pyplot' has no attribute '_REPL_DISPLAYHOOK'\n"

@tacaswell
Copy link
Member Author

Oh, that makes sense, on main @anntzer unified how we track if the repl hook is installed.

@tacaswell
TST: Adjust to state tracking on 3.5.x branch
d4879e5 
The implementation of tracking if the repl displayhook is installed changed on
main.  Adjust the backported test to work with the old way.
@tacaswell tacaswell force-pushed the backport_switch_backend branch from 17dbe4d to d4879e5 Compare May 27, 2022 00:16
@jklymak jklymak merged commit c5a24ff into matplotlib:v3.5.x Jun 2, 2022
@jklymak
Copy link
Member

jklymak commented Jun 2, 2022

I took the liberty of squash merging this

@tacaswell tacaswell deleted the backport_switch_backend branch June 2, 2022 13:18
@QuLogic QuLogic mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@tacaswell @QuLogic @jklymak @anntzer