Skip to content

Deprecate passing most Legend arguments positionally #23166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented May 31, 2022

PR Summary

There are so many of them, it really doesn't make sense to do positionally.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic added this to the v3.6.0 milestone May 31, 2022
There are so many of them, it really doesn't make sense to do
positionally.
@oscargus oscargus merged commit a7a44b6 into matplotlib:main May 31, 2022
@QuLogic QuLogic deleted the legend-kwargs branch May 31, 2022 07:19
@timhoffm
Copy link
Member

While at it, should we do this for most Artists?

@QuLogic
Copy link
Member Author

QuLogic commented May 31, 2022

Probably; I noticed this in #23140 (which has since dropped the new argument to Legend), but I'm sure it can apply to most of the others.

andrew-fennell pushed a commit to andrew-fennell/matplotlib that referenced this pull request Jun 14, 2022
There are so many of them, it really doesn't make sense to do
positionally.
@EwoutH
Copy link

EwoutH commented Oct 9, 2022

I couldn't find this change in the API Changes for 3.6.0, should I look somewhere else for the documentation on this?

@QuLogic
Copy link
Member Author

QuLogic commented Oct 21, 2022

#23177 made it generally applicable to all Artists; it is the entry here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants