Add pytest-xvfb as test dependency #23231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a little pet peeve. Please mention what it is that a PR is doing in
plain english.
It appears that this tool would suppress any gui windows that the test
suite might raise.
…On Thu, Jun 9, 2022 at 4:41 PM Oscar Gustafsson ***@***.***> wrote:
PR Summary
Run tests using xvfb if it is installed, see
https://github.com/The-Compiler/pytest-xvfb/
Helps with #23096 <#23096>
(if on Linux and xvfb installed...).
PR Checklist
*Tests and Styling*
- Has pytest style unit tests (and pytest passes).
- Is Flake 8 <https://flake8.pycqa.org/en/latest/> compliant (install
flake8-docstrings and run flake8 --docstring-convention=all).
*Documentation*
- New features are documented, with examples if plot related.
- New features have an entry in doc/users/next_whats_new/ (follow
instructions in README.rst there).
- API changes documented in doc/api/next_api_changes/ (follow
instructions in README.rst there).
- Documentation is sphinx and numpydoc compliant (the docs should build
<https://matplotlib.org/devel/documenting_mpl.html#building-the-docs>
without error).
------------------------------
You can view, comment on, or merge this pull request online at:
#23231
Commit Summary
- 00a171e
<00a171e>
Use pytest-xvfb
File Changes
(2 files <https://github.com/matplotlib/matplotlib/pull/23231/files>)
- *M* .github/workflows/tests.yml
<https://github.com/matplotlib/matplotlib/pull/23231/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957f>
(7)
- *M* requirements/testing/all.txt
<https://github.com/matplotlib/matplotlib/pull/23231/files#diff-24a120ba0f9cd696de33ba40c58fe0732188f1d9ecf3fcb9d8f8ac20f6bd0290>
(1)
Patch Links:
- https://github.com/matplotlib/matplotlib/pull/23231.patch
- https://github.com/matplotlib/matplotlib/pull/23231.diff
—
Reply to this email directly, view it on GitHub
<#23231>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACHF6EJQYOOWMD6IC7KTSLVOJJGXANCNFSM5YLKRUHQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
jklymak
approved these changes
Jun 20, 2022
QuLogic
approved these changes
Jun 21, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
With this, there is no need to explicitly start xvfb (program to "get a display" when running without a display, such as on the CI). When running tests locally and xvfb is installed, no windows will pop up.
For options to actually pop up the windows and more info, see https://github.com/The-Compiler/pytest-xvfb/
Helps with #23096 (if on Linux and xvfb installed...).
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).