Skip to content

Add PathCollection test for ps backend #23254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

Add PathCollection test for ps backend #23254

merged 1 commit into from
Sep 12, 2022

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Jun 11, 2022 •
edited
Loading

PR Summary

This was not tested as all earlier.

Also added a missing argument to the draw_text doc-string.

I have problems figuring out how to obtain a PathCollection which leads to optimized rendering. Also, I have noted that it seems possible to save the reference image as pdf instead. Any input here would be appreciated.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus force-pushed the testpsscatter branch 2 times, most recently from 45b6a31 to 27bf604 Compare July 19, 2022 09:31
@oscargus oscargus changed the title Add PathCollection test for ps backend Add PathCollection and Gouraud triangle tests for ps backend Jul 19, 2022
@oscargus oscargus force-pushed the testpsscatter branch 2 times, most recently from 8d60936 to 1b176a2 Compare July 19, 2022 10:34
@oscargus oscargus changed the title Add PathCollection and Gouraud triangle tests for ps backend Add PathCollection test for ps backend Jul 19, 2022
@oscargus oscargus marked this pull request as ready for review July 19, 2022 11:27
@QuLogic QuLogic added this to the v3.7.0 milestone Sep 12, 2022
@QuLogic QuLogic merged commit b7381e9 into matplotlib:main Sep 12, 2022
@oscargus oscargus deleted the testpsscatter branch September 13, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
backend: ps topic: testing
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oscargus @QuLogic @greglucas