Skip to content

Fix Colorbar extend patches to have correct alpha #23260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2022
Merged

Fix Colorbar extend patches to have correct alpha #23260

merged 1 commit into from
Jun 14, 2022

Conversation

AnnaMastori
Copy link
Contributor

PR Summary

Add self.alpha to PathPatch creation in _do_extends method in order for the extend patches of the colorbar to have the correct alpha. (closes #22970)

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus merged commit 806d407 into matplotlib:main Jun 14, 2022
jklymak
jklymak reviewed Jun 14, 2022
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-facto, but it would be nice if a test were added for this...

@oscargus
Copy link
Member

oscargus commented Jun 14, 2022 •
edited
Loading

I thought about that as well, but then couldn't really come up with anything better than an image test. I'll add one in #22865.

Edit: I can add one elsewhere. Realized that I had messed up my local handling of #22865.

This was referenced Jun 14, 2022
Merged
Merged
@QuLogic QuLogic modified the milestones: v3.6.0, v3.5.3 Jun 14, 2022
@QuLogic
Copy link
Member

QuLogic commented Jun 15, 2022

meeseeksdev backport to v3.5.x

@meeseeksmachine meeseeksmachine mentioned this pull request Jun 15, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 15, 2022
@oscargus @meeseeksmachine
Backport PR matplotlib#23260: Fix Colorbar extend patches to have cor…
de4088d 
…rect alpha
QuLogic pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 21, 2022
@oscargus @QuLogic
Backport PR matplotlib#23260: Fix Colorbar extend patches to have cor…
cddda1f 
…rect alpha
timhoffm added a commit that referenced this pull request Jun 21, 2022
@timhoffm
Merge pull request #23275 from meeseeksmachine/auto-backport-of-pr-23…
ad1d91d 
…260-on-v3.5.x

Backport PR #23260 on branch v3.5.x (Fix Colorbar extend patches to have correct alpha)
@oscargus oscargus mentioned this pull request Nov 2, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
topic: color/colorbar
Projects
None yet
Milestone
v3.5.3
Development

Successfully merging this pull request may close these issues.

[Bug]: Colorbar extend patches do not have correct alpha
6 participants
@AnnaMastori @oscargus @QuLogic @jklymak @timhoffm @NickolasGiannatos