-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
negative_linestyles kwarg in contour.py #23266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
negative_linestyles kwarg in contour.py #23266
Conversation
lib/matplotlib/contour.py
Outdated
negative_linestyles : None or str, optional | ||
{'solid', 'dashed', 'dashdot', 'dotted'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
negative_linestyles : None or str, optional | |
{'solid', 'dashed', 'dashdot', 'dotted'} | |
negative_linestyles : {*None*, 'solid', 'dashed', 'dashdot', 'dotted'}, \ | |
optional |
(or where ever the line should break.)
Sorry, something went wrong.
All reactions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and made this exact change. It matches linestyles
formatting... I'm not sure where I saw the formatting I initially had.
Sorry, something went wrong.
All reactions
41bc9bb
to
1b3b390
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, and useful.
Sorry, something went wrong.
All reactions
-
👍 1 reaction
Successfully merging this pull request may close these issues.
[ENH]: contour kwarg for negative_linestyle
PR Summary
I made the
negative_linestyles
for contours toggle-able via kwarg. The only way to toggle this currently is withrcParams
.I am re-opening this issue from a fresh branch. There was some discussion in #23102.
In the attached issue, we had some discussion on whether this is a good idea or not, but I think it is worth considering. We can maintain current functionality and just apply the kwarg if it is defined. This will not break previous functionality. I wrote some tests for this, but I know they can be improved. I'm not completely certain on using baseline_images with parametrized inputs.
Please use this PR and the attached issue to discuss whether this is a good idea or not. I'm happy to take this in a different direction if there are some better ideas!
Closes #23028
Previous
With this PR
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).