Simplify binary data handling in ps backend. #23294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
The only potential "problem" is that the deprecation note says: "Vendor the code of the similarly named private functions if you rely on these functions." https://github.com/matplotlib/matplotlib/blob/main/doc/api/next_api_changes/deprecations/22797-OG.rst
But hopefully people will understand anyway (there are several functions deprecated, so probably not worthwhile special handling this one).
|
Oh, if there is a suitable test to add that would be great! (Or are the lines actually tested despite the report?) |
|
It is quite possible that this is actually not tested; will add a test... |
|
Test added. |
- bytes.hex() can now perform linewrapping itself, so use that in draw_image. - draw_gouraud_triangles can rely on PostScript's hexstring format (`<...>` instead of `(...)`) and thus on bytes.hex() too. This makes _quote_ps_string fully unused, thus tweak the deprecation of quote_ps_string. Also add a test for PostScript Gouraud shading, which was previously not covered at all.
timhoffm
approved these changes
Jun 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draw_image.
(
<...>instead of(...)) and thus on bytes.hex() too. This makes_quote_ps_string fully unused, thus tweak the deprecation of
quote_ps_string.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).