Skip to content

Revert "Try to unbreak CI by xfailing OSX Tk tests" #23355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jun 27, 2022

The upstream issue has been closed, so let's see if it will work again.

Reverts #23095

@QuLogic
Copy link
Member Author

QuLogic commented Jun 27, 2022

Hmm, looking at the tags, it probably hasn't been deployed yet, but I guess we'll see how the CI goes. If it's not ready yet, I'll leave this as draft, and monitor upstream for when we can re-enable.

@QuLogic QuLogic marked this pull request as draft June 28, 2022 01:04
@tacaswell tacaswell closed this Jul 9, 2022
@tacaswell tacaswell reopened this Jul 9, 2022
@QuLogic QuLogic closed this Jul 21, 2022
@QuLogic QuLogic reopened this Jul 21, 2022
@QuLogic QuLogic closed this Jul 22, 2022
@QuLogic
Copy link
Member Author

QuLogic commented Jul 22, 2022

They say it's being deployed...

@QuLogic QuLogic reopened this Jul 22, 2022
@QuLogic QuLogic marked this pull request as ready for review August 13, 2022 01:46
@QuLogic
Copy link
Member Author

QuLogic commented Aug 13, 2022

Only failure is on push, which I can't restart, but the pull_request build did pass.

@tacaswell tacaswell added this to the v3.6.0 milestone Aug 13, 2022
@tacaswell tacaswell merged commit 5b5cc0e into main Aug 13, 2022
@tacaswell tacaswell deleted the revert-23095-osx-tk-xfail branch August 13, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants