Small cleanups to animation. #23370
Merged
Small cleanups to animation. #23370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't hard-code/expose CREATE_NO_WINDOW on Windows (I'll aggressively remove the global without a deprecation here), taking advantage of the fact that the subprocess module now exposes the constant on Windows. - Clarify the documentation in the rcParams for ffmpeg_path and convert_path. 1) subprocess.Popen (which is really what we're using) is not exactly just searching in the $PATH -- see the big warning to that respect in the CPython docs. 2) One doesn't actually need to put an absolute path for convert on Windows -- Matplotlib now handles this transparently.
dopplershift
approved these changes
Jun 29, 2022
6 tasks
QuLogic
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the global without a deprecation here), taking advantage of the
fact that the subprocess module now exposes the constant on Windows.
convert_path. 1) subprocess.Popen (which is really what we're using)
is not exactly just searching in the $PATH -- see the big warning to
that respect in the CPython docs. 2) One doesn't actually need to put
an absolute path for convert on Windows -- Matplotlib now handles this
transparently.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).