Use tick_params more often over tick iteration #23377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jul 1, 2022
examples/axes_grid1/demo_axes_rgb.py
Outdated
| @@ -59,11 +59,8 @@ def demo_rgb2(): | |||
| ax_b.imshow(im_b) | |||
|
|
|||
| for ax in fig.axes: | |||
| ax.tick_params(axis='both', direction='in') | |||
| ax.tick_params(axis='both', direction='in', color='w') | |||
There was a problem hiding this comment.
Suggested change
| ax.tick_params(axis='both', direction='in', color='w') | |
| ax.tick_params(direction='in', color='w') |
Both is the default.
|
Are these the easy cases or only randomly some? Because if the first we should comment on #23372 and maybe even remove the good first issue. |
|
I believe it's everything that doesn't need alignment. |
Related to, but does not completely fix, matplotlib#23372.
timhoffm
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Related to, but does not completely fix, #23372.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).