Consistently set label on axis with units #23417
Merged
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7acb640 to
9e68676
Compare
jklymak
reviewed
Jul 12, 2022
timhoffm
previously requested changes
Jul 12, 2022
There was a problem hiding this comment.
I'm convinced this is the wrong way. See #23416 (comment). Please discuss there. I'm blocking this until we've reached a conclusion there.
timhoffm
reviewed
Jul 21, 2022
3c08008 to
c432940
Compare
timhoffm
approved these changes
Sep 19, 2022
QuLogic
reviewed
Nov 24, 2022
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
QuLogic
approved these changes
Nov 26, 2022
This was referenced Feb 15, 2023
tacaswell
added a commit
that referenced
this pull request
Feb 22, 2023
Revert #23417 (Consistently set label on axis with units)
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 22, 2023
…et label on axis with units)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #23416. The issue was an incorrect check on whether units needed to be updated.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).