Skip to content

Tweak pgf escapes. #23427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2022
Merged

Tweak pgf escapes. #23427

merged 2 commits into from
Jul 17, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 14, 2022 •
edited
Loading

  • We don't need to escape underscores manually, but can rely on the
    underscore package like we already do for usetex.
  • We don't actually escape dollars (we parse them as math delimiters
    first).
  • Slightly tweak error message generation.
  • Move escaping tests before the big create_figure definition, which
    is used for further tests below.

(Moves towards #23381 (comment), where I suggest to try to do away with pgf escapes entirely.)

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus
Copy link
Member

What will happen with a single $ now? (Same as before?)

@anntzer
Copy link
Contributor Author

anntzer commented Jul 15, 2022

Previously, "a$b" would be incorrectly treated as a$b$ (we see the first dollar, switch to math mode, and don't bother checking that a second one is present. With this patch, this now errors out, which is arguably more correct.

@anntzer anntzer force-pushed the pgf_ branch 3 times, most recently from 606b714 to db1cf31 Compare July 15, 2022 15:16
anntzer added 2 commits July 17, 2022 20:50
@anntzer
Tweak pgf escapes.
b5c535b 
- We don't need to escape underscores manually, but can rely on the
  underscore package like we already do for usetex.
- We don't actually escape dollars (we parse them as math delimiters
  first).
- Slightly tweak error message generation.
- Move escaping tests before the big `create_figure` definition, which
  is used for further tests below.
@anntzer
Help troubleshooting of latex failures.
e8acd57
@timhoffm timhoffm merged commit 8b5516b into matplotlib:main Jul 17, 2022
@QuLogic QuLogic added this to the v3.6.0 milestone Jul 17, 2022
@anntzer anntzer deleted the pgf_ branch July 18, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
backend: pgf
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @oscargus @timhoffm @QuLogic