Skip to content

Backport PR #23430 on branch v3.5.x (Fix divide by 0 runtime warning) #23440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mpl_toolkits/mplot3d/proj3d.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def _line2d_seg_dist(p1, p2, p0):

x01 = np.asarray(p0[0]) - p1[0]
y01 = np.asarray(p0[1]) - p1[1]
if np.all(p1 == p2):
if np.all(p1[0:2] == p2[0:2]):
return np.hypot(x01, y01)

x21 = p2[0] - p1[0]
Expand Down
10 changes: 6 additions & 4 deletions lib/mpl_toolkits/tests/test_mplot3d.py
Original file line number Diff line number Diff line change
Expand Up @@ -1004,11 +1004,13 @@ def test_lines_dists():
def test_lines_dists_nowarning():
# Smoke test to see that no RuntimeWarning is emitted when two first
# arguments are the same, see GH#22624
p0 = (10, 30)
p1 = (20, 150)
proj3d._line2d_seg_dist(p0, p0, p1)
p0 = (10, 30, 50)
p1 = (10, 30, 20)
p2 = (20, 150)
proj3d._line2d_seg_dist(p0, p0, p2)
proj3d._line2d_seg_dist(p0, p1, p2)
p0 = np.array(p0)
proj3d._line2d_seg_dist(p0, p0, p1)
proj3d._line2d_seg_dist(p0, p0, p2)


def test_autoscale():
Expand Down