Move the common implementation of Axes.set_x/y/zscale to Axis. #23500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... together with an _axis_method_wrapper. It may be worth trying to figure out later whether Axis._set_scale and Axis._set_axes_scale need to have subtly different behaviors...
|
The 3D-versions were not tested earlier. Would be nice to have a test that passes both before and after this PR. |
|
3D axes don't actually meaningfully support any scales other than linear, so I don't think we can really write meaningful tests there. Note that if anything this PR already improves the test coverage by getting rid of untested code (Axes3D.set_{x,y,z}scale). |
oscargus
approved these changes
Aug 1, 2022
|
The docs failure is understood as the sphinx-gallery reset issue, should not block. The difference is that the autoscaling is now conditional, but I suspect that is OK. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... together with an _axis_method_wrapper.
It may be worth trying to figure out later whether Axis._set_scale and
Axis._set_axes_scale need to have subtly different behaviors...
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).