-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add tests for WebAgg using Playwright #23540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Can you mask the resize grip by drawing a white rectangle on top using imagemagic? |
looks like we need some extra steps in the CI setup? |
Actually, I forgot we have access to which browser is running the test, so I could just have two test images... I'll see what the diff looks like. |
0e73936
to
9ec8bbc
Compare
So this is nearly working on GitHub Actions. The current failure is on macOS. For some reason, the canvas gets a border and it's black on Linux, but blue on macOS. There's also some slight difference in the resize grip size. AppVeyor only fails one test, so it's likely a similar deal. Azure passes on Linux, but fails on macOS and Windows, but on several more tests. I'm not sure why that is yet. |
cbe2368
to
427df9c
Compare
This prevents them from conflicting when run in parallel. Even though there is some attempt to pick alternative ports, that seems to cause a socket leak somewhere in Tornado, which Pytest converts to an error, so we have to do it manually.
PR Summary
This may make WebAgg the most tested backend...
I'm not sure what to do about the screenshot test, as I really want to confirm that the figure is sent to the browser, but browsers differ in how they show the resize grip, which causes te comparison to fail.
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).