Skip to content

Clean up code in tri #23561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

Clean up code in tri #23561

merged 1 commit into from
Aug 9, 2022

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Aug 5, 2022

PR Summary

Some clean ups:

  • Argument checking
  • Simplify code
  • Minor doc fix

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

timhoffm
timhoffm reviewed Aug 5, 2022
View reviewed changes
@QuLogic QuLogic merged commit fa89889 into matplotlib:main Aug 9, 2022
@QuLogic QuLogic added this to the v3.6.0 milestone Aug 9, 2022
@oscargus oscargus deleted the tricleanups branch August 10, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: tri
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oscargus @QuLogic @timhoffm