Skip to content

Cleanup axis3d.Axis.draw #23582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

Cleanup axis3d.Axis.draw #23582

merged 1 commit into from
Aug 9, 2022

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Aug 8, 2022

PR Summary

Remove a bunch of redundant lookups and computations.

Restructured code a bit.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus force-pushed the axis3ddrawcleanup branch 2 times, most recently from d5fd401 to 94cd9f8 Compare August 8, 2022 13:18
@oscargus
Copy link
Member Author

oscargus commented Aug 8, 2022

The test failure is caused by gristlabs/asttokens#85

Not sure what the solution is:

  1. Install astroid
  2. Mark asttokens!=2.0.6
  3. Wait for asttokens 2.0.7.

As we do not have any (direct) dependency on asttokens it doesn't really seem to make sense to select 2.

@alexmojaki
Copy link

asttokens 2.0.7 is released

@oscargus
Copy link
Member Author

oscargus commented Aug 8, 2022

asttokens 2.0.7 is released

Great, thanks!

@oscargus oscargus closed this Aug 8, 2022
@oscargus oscargus reopened this Aug 8, 2022
@oscargus oscargus force-pushed the axis3ddrawcleanup branch 3 times, most recently from 011b244 to 8ac3470 Compare August 8, 2022 22:04
QuLogic
QuLogic approved these changes Aug 9, 2022
View reviewed changes
timhoffm
timhoffm approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After addressing @QuLogic ’s comment.

@oscargus oscargus force-pushed the axis3ddrawcleanup branch from 8ac3470 to 38567d2 Compare August 9, 2022 19:05
@QuLogic QuLogic merged commit a84ecf1 into matplotlib:main Aug 9, 2022
@QuLogic QuLogic added this to the v3.6.0 milestone Aug 9, 2022
@oscargus oscargus deleted the axis3ddrawcleanup branch August 10, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer left review comments

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: mplot3d
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@oscargus @alexmojaki @QuLogic @anntzer @timhoffm