Fix issues in examples, docs, and tutorials #23605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f432e81 to
b38e339
Compare
oscargus
commented
Aug 11, 2022
| @@ -129,7 +129,7 @@ def _contour_args(self, args, kwargs): | |||
| The colors of the levels, i.e., the contour %%(type)s. | |||
|
|
|||
| The sequence is cycled for the levels in ascending order. If the sequence | |||
| is shorter than the number of levels, it's repeated. | |||
| is shorter than the number of levels, it is repeated. | |||
There was a problem hiding this comment.
Not really required. More a consequence of the other instance being incorrect.
b830eb7 to
896d1cd
Compare
oscargus
commented
Aug 11, 2022
|
|
||
| # Align the minor tick label | ||
| for label in ax.get_xticklabels(minor=True): |
There was a problem hiding this comment.
This is maybe not the best thing to loop over. But this is the method mentioned at the top, so from that perspective it makes more sense.
oscargus
commented
Aug 11, 2022
timhoffm
reviewed
Aug 11, 2022
896d1cd to
137ebfa
Compare
timhoffm
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Spent some time looking through the documentation tags and sort out a few.
Closes #8187
Closes #22746
Closes #23220
Adds examples to Artist methods
Use
tick_paramsfor a few more things.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).