Skip to content

TST: be more forgiving about IDing Noto #23610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2022
Merged

TST: be more forgiving about IDing Noto #23610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions lib/matplotlib/tests/test_ft2font.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ def test_fallback_smoke():


@pytest.mark.parametrize('family_name, file_name',
[("WenQuanYi Zen Hei", "wqy-zenhei.ttc"),
("Noto Sans CJK JP", "NotoSansCJK-Regular.ttc")]
[("WenQuanYi Zen Hei", "wqy-zenhei"),
("Noto Sans CJK JP", "NotoSansCJK")]
)
@check_figures_equal(extensions=["png", "pdf", "eps", "svg"])
def test_font_fallback_chinese(fig_test, fig_ref, family_name, file_name):
fp = fm.FontProperties(family=[family_name])
if Path(fm.findfont(fp)).name != file_name:
if file_name not in Path(fm.findfont(fp)).name:
pytest.skip(f"Font {family_name} ({file_name}) is missing")

text = ["There are", "几个汉字", "in between!"]
Expand All @@ -81,13 +81,14 @@ def test_font_fallback_chinese(fig_test, fig_ref, family_name, file_name):
@pytest.mark.parametrize(
"family_name, file_name",
[
("WenQuanYi Zen Hei", "wqy-zenhei.ttc"),
("Noto Sans CJK JP", "NotoSansCJK-Regular.ttc"),
("WenQuanYi Zen Hei", "wqy-zenhei"),
("Noto Sans CJK JP", "NotoSansCJK"),
],
)
def test__get_fontmap(family_name, file_name):
fp = fm.FontProperties(family=[family_name])
if Path(fm.findfont(fp)).name != file_name:
found_file_name = Path(fm.findfont(fp)).name
if file_name not in found_file_name:
pytest.skip(f"Font {family_name} ({file_name}) is missing")

text = "There are 几个汉字 in between!"
Expand All @@ -100,6 +101,6 @@ def test__get_fontmap(family_name, file_name):
fontmap = ft._get_fontmap(text)
for char, font in fontmap.items():
if ord(char) > 127:
assert Path(font.fname).name == file_name
assert Path(font.fname).name == found_file_name
else:
assert Path(font.fname).name == "DejaVuSans.ttf"