Simplify/fix save_diff_image. #23659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had noticed this but it had not bothered me enough to chase down.... |
tacaswell
approved these changes
Aug 18, 2022
|
This might allow us to reduce the tolerances on some of the known-bad tests. Do we have a test that still fail on slightly different images? I guess the night-mare risk here is we put a bug in this code and start passing wrong images and effectively invalidate a most of our test suite. |
- The previous `*255*10` factor was necessary when using the old _png module to read images, which read them as 0-1 floats, the 255 factor was needed prior to conversion to uint8. Now we use pillow everywhere in matplotlib.testing.compare and work with uint8 throughout, so the extra 255 is incorrect (it basically caused any slight difference to be fully saturated). - We don't use _png to write the diffs anymore, and pillow handles RGB just fine, so we don't need to add an alpha channel if it's not there.
|
|
|
The tolerance is compared with the value computed in |
|
Given @anntzer 's comment I rectract my request we hold this for 3.7. |
QuLogic
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*255*10factor was necessary when using the old _pngmodule to read images, which read them as 0-1 floats, the 255 factor
was needed prior to conversion to uint8. Now we use pillow everywhere
in matplotlib.testing.compare and work with uint8 throughout, so the
extra 255 is incorrect (it basically caused any slight difference to
be fully saturated).
just fine, so we don't need to add an alpha channel if it's not there.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).