Api deprecate cmap functions #23668
Merged
Api deprecate cmap functions #23668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
reviewed
Aug 19, 2022
07d80fd to
396c88c
Compare
418ee64 to
8f0c814
Compare
|
OK, really done force-pushing now... |
greglucas
approved these changes
Aug 19, 2022
QuLogic
reviewed
Aug 19, 2022
| @@ -2250,7 +2250,7 @@ def test_contour_hatching(): | |||
| x, y, z = contour_dat() | |||
| fig, ax = plt.subplots() | |||
| ax.contourf(x, y, z, 7, hatches=['/', '\\', '//', '-'], | |||
| cmap=plt.get_cmap('gray'), | |||
| cmap=mpl.colormaps['gray'], | |||
There was a problem hiding this comment.
Can we just use strings if we aren't using resample or using the Colormap for anything?
There was a problem hiding this comment.
It can, but I was just mechanically changing (a lot of this was done with search-and-relpace)
There was a problem hiding this comment.
I've decided to leave this. It makes the test a bit more complicated, but I do not know if we are definitely exercising the ability to pass Colormap objects through this top level API else where.
|
I'll try to get these changes in first thing tomorow morning, will not be offended if you want to push change @QuLogic . |
timhoffm
reviewed
Aug 19, 2022
8f0c814 to
9321499
Compare
|
@timhoffm I think this is ready to review again. |
9321499 to
ae90168
Compare
e830ea7 to
093ee4a
Compare
timhoffm
reviewed
Aug 19, 2022
- matplotlib.cm.get_cmap - matplotlib.cm.register_cmap - matplotlib.cm.unregister_cmap - matplotlib.pyplot.register_cmap in preference for working with the ColormapRegistry on the top level module. Co-authored-by: Greg Lucas <greg.m.lucas@gmail.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Add it to the rendered docs.
f51e784 to
a987e31
Compare
|
@timhoffm I think I got everything |
timhoffm
approved these changes
Aug 19, 2022
|
Anybody can merge when green. |
QuLogic
approved these changes
Aug 20, 2022
This was referenced Aug 20, 2022
trexfeathers
added a commit
to trexfeathers/iris
that referenced
this pull request
Sep 28, 2022
pp-mo
pushed a commit
to SciTools/iris
that referenced
this pull request
Sep 28, 2022
* Change deprecated MPL colormap registration - matplotlib/matplotlib#23668. * Adapt benchmark for importing palette to cope with MPL 3.6. * What's New entry. * What's New typo. * Reformat import_iris imports.
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/niworkflows
that referenced
this pull request
Apr 17, 2024
matplotlib.cm.get_cmap → matplotlib.colormaps This is new in matplotlib 3.9: matplotlib/matplotlib#23668
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/niworkflows
that referenced
this pull request
Apr 17, 2024
matplotlib.cm.get_cmap → matplotlib.colormaps matplotlib/matplotlib#23668
effigies
pushed a commit
to nipreps/niworkflows
that referenced
this pull request
Apr 17, 2024
matplotlib.cm.get_cmap → matplotlib.colormaps matplotlib/matplotlib#23668 Fixes #865.
effigies
pushed a commit
to nipreps/niworkflows
that referenced
this pull request
Jun 10, 2024
matplotlib.cm.get_cmap → matplotlib.colormaps matplotlib/matplotlib#23668 Fixes #865.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is my attempt to turn the crank on the depractions on the cm functions.
The changes were more extensive than I anticipated
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).