CI: Azure update from ubuntu-18.04 to ubuntu-latest and ubuntu-20.04 #23669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42097ad to
5e77a67
Compare
scottshambaugh
commented
Aug 19, 2022
| @@ -97,7 +97,7 @@ stages: | |||
| graphviz \ | |||
| inkscape \ | |||
| libcairo2 \ | |||
| libgirepository-1.0.1 \ | |||
| libgirepository-1.0-1 \ | |||
There was a problem hiding this comment.
No idea what this is used for or why the packaged made a minor name change like this, but the old name was broken on 20.04.
|
As further conversation, I noticed this incidentally just a few days before github actions was going to start sporadically failing tests, which I think is a pretty ham-fisted way to raise awareness of an upcoming deprecation and something we should keep ahead of. The next time this will happen is in another two years and I doubt anyone will happen to remember then. Perhaps we should raise azure warnings as errors? I'm not familiar with how often there are frivolous warnings in the pipeline, so that may hurt more than help. |
oscargus
approved these changes
Aug 19, 2022
QuLogic
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In the Azure config, the Ubuntu version is pinned to 18.04. However, the following warning is being raised in the Azure pipelines.
The linked issue actions/runner-images#6002 says that 18.04 will be unsupported on 12/1/22, and the first "brownout" where jobs will fail will happen
August 22, 12:00 UTC - August 22, 16:00 UTC. IMO it's a poor approach to only have the warning up for 2 weeks before breaking tests, but best to get ahead of it at any rate.This PR updates most of the linux versions to
ubuntu-latest, and pins the lowest python version toubuntu-20.04for compatibility. 20.04 is a long-term-support Ubuntu release.Edit: Some of this was covered in #23584 but it looks like Azure was missed.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).