Skip to content

Clarify error for colorbar with unparented mappable #23740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 25, 2022

PR Summary

Fixes #23709

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo the suggested changes to the deprecation note.

@QuLogic QuLogic force-pushed the parentless-mappable branch from 6ada95f to 5509ebb Compare August 25, 2022 23:13
@tacaswell tacaswell added this to the v3.6.0 milestone Aug 25, 2022
@timhoffm timhoffm merged commit 86d5797 into matplotlib:main Aug 26, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 26, 2022
@QuLogic QuLogic deleted the parentless-mappable branch August 26, 2022 07:37
QuLogic added a commit that referenced this pull request Aug 26, 2022
…740-on-v3.6.x

Backport PR #23740 on branch v3.6.x (Clarify error for colorbar with unparented mappable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: colorbar with unattached mappables can't steal space
3 participants