Remove useless semicolons in "Introductory / Basic Usage" tutorial #23796
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
This comment was marked as outdated.
This comment was marked as outdated.
|
On second thought, that output is also in https://matplotlib.org/3.6.0/tutorials/introductory/quick_start.html#a-simple-example which is counter to what I expected so maybe they are useless... There is clearly something I do not understand about sphinx-gallery here. |
|
IMHO we should to discuss with sphinx-gallery to make showing outputs configurable. Even if the semicolon worked it can be a little confusing for users not familiar with it. Ideally that option could be configured on a global/file/block basis and be overridden by the more specific ones; i.e. global=off, this block=on. |
|
You can now configure |
@tacaswell : as I explained in sphinx-gallery/sphinx-gallery#891: putting a semicolon after the last expression doesn't work here as the code is first compiled into an AST and then the last expression is taken from the tree where the semicolon as code delimiter isn't present, see code. |
|
@timhoffm in fact the PR is still valid - the semicolons are useless in this case (see #23796 (comment)) and should be removed (along with the corresponding flake ignore) |
|
@StefRe thanks for the correction. |
|
"power cycled" to get the azure to re-run |
|
Thanks @gustavi, and congratulations on your first contribution to Matplotlib! |
PR Summary
Remove useless semicolons in tutorial https://matplotlib.org/stable/tutorials/introductory/usage.html#sphx-glr-tutorials-introductory-usage-py.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).