Revert "Refactor handling of tick and ticklabel visibility in Axis.clear" #23834
+8
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar()" This reverts commit 2357c92.
QuLogic
approved these changes
Sep 8, 2022
jklymak
approved these changes
Sep 8, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 8, 2022
…icklabel visiblity in Axis.clear"
timhoffm
pushed a commit
that referenced
this pull request
Sep 9, 2022
…isiblity in Axis.clear" (#23838) Co-authored-by: Jody Klymak <jklymak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This reverts commit 2357c92. (#22587)
Reversal due to a regression #23808.
Decision on the dev call: We revert this change so that the exact code from 3.5 is still used in 3.6.
We plan to have a full discussion on what
clear()should do for 3.7.