Expire parameter renaming and deletion and attribute privatization from 3.5 #23874
Conversation
543b07f to
e5a045d
Compare
| @@ -468,8 +467,7 @@ def _print_pil(self, filename_or_obj, fmt, pil_kwargs, metadata=None): | |||
| filename_or_obj, self.buffer_rgba(), format=fmt, origin="upper", | |||
| dpi=self.figure.dpi, metadata=metadata, pil_kwargs=pil_kwargs) | |||
|
|
|||
| @_api.delete_parameter("3.5", "args") | |||
| def print_png(self, filename_or_obj, *args, | |||
| def print_png(self, filename_or_obj, | |||
There was a problem hiding this comment.
Once you expire a delete_parameter, all subsequent parameters also become kwonly (as it was impossible to pass them positionally during the deprecation period without triggering the deprecation). Ditto for all other instances below.
There was a problem hiding this comment.
I was thinking about that. Makes sense!
|
For the removal notes, please add a bit more context than last time. When X is removed from Y where Y is 3 levels deep in an import tree, it is very hard to tell whether it's a relevant thing. See the changes in #23814 for examples. |
|
I've realized that the release notes is really the problem here. It may be that I close this and do parts gradually as for some of these I do not really have much context and the earlier notes does not give much info either. |
|
Closing this as it must be done in steps to be manageable. |
PR Summary
Will add a (quite long) release note.
Skipped widgets.py as it was a bit confusing at stages. But apart from that all renaming, deletion and privatization should be gone.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).