Skip to content

CI: prefer (older) binaries over (newer) sdists #23886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

tacaswell
Copy link
Member

PR Summary

Try to fix installing test deps on windows + mac

@tacaswell tacaswell added this to the v3.6.0 milestone Sep 14, 2022
@tacaswell
Copy link
Member Author

I started out planning to pin pikepdf back, but thought to try --prefer-binary before sorting out how to do platfrom specific pinning.

@tacaswell
Copy link
Member Author

It looks like it is working, I intend to self-merge if this is green.

@tacaswell
Copy link
Member Author

The appveyor failure is an upload not test failure.

@tacaswell
Copy link
Member Author

Well, I made the merge rules also apply to admins so I can not.

@QuLogic
Copy link
Member

QuLogic commented Sep 14, 2022

This file is in the documentation (through dev/dev-requirements.txt); do we want to force this preference on developers? Or just apply it to CI?

@tacaswell
Copy link
Member Author

I am OK with having this applied for developers too (we are so loose about pinning anyway I think soft-pinning back is OK).

There is motion to make this the default behavior in pip as well.

@oscargus
Copy link
Member

How would this relate to environment.yml?

@QuLogic
Copy link
Member

QuLogic commented Sep 15, 2022

It looks like there's a conda-forge feedstock for it: https://github.com/conda-forge/pikepdf-feedstock So we should move to that and then it would definitely be a binary.

@QuLogic
Copy link
Member

QuLogic commented Sep 15, 2022

Oops, I should have checked the history first; we used to use it, but switched to pip because there were no Windows conda-forge packages, and it seems like there still aren't.

@oscargus
Copy link
Member

Could one add this switch to the pip-section there? (I could try off course...)

QuLogic added a commit that referenced this pull request Sep 15, 2022
…886-on-v3.6.x

Backport PR #23886 on branch v3.6.x (CI: prefer (older) binaries over (newer) sdists)
@tacaswell tacaswell deleted the ci_pin_pikepdf branch September 15, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants