Skip to content

Add missing label argument to barh docs #23887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 14, 2022

PR Summary

Also fix a few other inconsistencies with bar.

We could probably do some fanciness to prevent duplication here, but since this is a new feature in 3.6, I'd rather do it the simpler way to get this fixed sooner.

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic
Copy link
Member Author

QuLogic commented Sep 14, 2022

Also made the signature consistent with an explicit data, as that is added by the _preprocess_data decorator on bar, but we don't have that on barh as it is passed through and handled in bar automatically.

Also fix a few other inconsistencies with bar.
@timhoffm timhoffm merged commit 6a29803 into matplotlib:main Sep 15, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 15, 2022
tacaswell added a commit that referenced this pull request Sep 15, 2022
…887-on-v3.6.x

Backport PR #23887 on branch v3.6.x (Add missing label argument to barh docs)
@QuLogic QuLogic deleted the barh-label branch September 15, 2022 18:41
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Dec 19, 2022
Also fix a few other inconsistencies with bar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants