Fix issue with empty line in ps backend #23964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4aef735 to
0c53446
Compare
2 tasks
tacaswell
approved these changes
Sep 20, 2022
|
Approving your PR is easier than adding a test to mine :) |
tacaswell
reviewed
Sep 20, 2022
| # append the last entry | ||
| stream.append(curr_stream) | ||
| # append the last entry if exists | ||
| if curr_stream: |
There was a problem hiding this comment.
On consideration, I think the looser check here is better than what I had because I suspect other falsy things (like empty lists) would also break the consumer code.
anntzer
reviewed
Sep 21, 2022
| figure = Figure() | ||
| ax = figure.add_subplot(111) | ||
| ax.set_title('\nLower title') | ||
| ax.annotate(text='\nLower label', xy=(0, 0)) |
There was a problem hiding this comment.
Would a figtext (fig.text(...), no axes at all) be enough?
There was a problem hiding this comment.
It is. I've changed it.
dopplershift
approved these changes
Sep 22, 2022
0c53446 to
ad611f3
Compare
ad611f3 to
da3790f
Compare
|
Updated the test and seems to have lost the co-authorship from @tacaswell ... Not sure what you changed, but I think that it should be included here (since I pulled the PR to another computer before updating the test). |
|
You can click the commit links on the 'force-pushed' annotation line here. Looks like just a rebase to me. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 24, 2022
oscargus
added a commit
that referenced
this pull request
Sep 28, 2022
…964-on-v3.6.x Backport PR #23964 on branch v3.6.x (Fix issue with empty line in ps backend)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #23954
(Identical to #23910 which I forgot existed. This has a test though...)
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).