Skip to content

Fixed colorbar bug when yscaled length is 1 #23984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Fixed colorbar bug when yscaled length is 1 #23984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0858774
Fixed colorbar bug when yscaled length is 1
Andes0113 Sep 22, 2022
1f2418a
Added test
Andes0113 Sep 22, 2022
3338d20
Fixed flake issue with test
Andes0113 Sep 22, 2022
b99e758
Added smoke test for gh#23817
Andes0113 Sep 29, 2022
b2e5dfa
Added smoke test for gh#23817
Andes0113 Sep 29, 2022
501c00a
Fixed uniformfield test
Andes0113 Oct 1, 2022
5e581f9
Added check for contoured uniform fields
Andes0113 Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions lib/matplotlib/colorbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,8 +1221,10 @@ def _proportional_y(self):
if (isinstance(self.norm, colors.BoundaryNorm) or
self.boundaries is not None):
y = (self._boundaries - self._boundaries[self._inside][0])
y = y / (self._boundaries[self._inside][-1] -
self._boundaries[self._inside][0])
if (self._boundaries[self._inside][-1]
!= self._boundaries[self._inside][0]):
y = y / (self._boundaries[self._inside][-1] -
self._boundaries[self._inside][0])
# need yscaled the same as the axes scale to get
# the extend lengths.
if self.spacing == 'uniform':
Expand All @@ -1243,10 +1245,13 @@ def _proportional_y(self):
yscaled = np.ma.filled(norm(yscaled), np.nan)
# make the lower and upper extend lengths proportional to the lengths
# of the first and last boundary spacing (if extendfrac='auto'):
automin = yscaled[1] - yscaled[0]
automax = yscaled[-1] - yscaled[-2]
extendlength = [0, 0]
if self._extend_lower() or self._extend_upper():
automin = yscaled[0]
automax = yscaled[0]
if len(yscaled) > 1:
automin = yscaled[1] - yscaled[0]
automax = yscaled[-1] - yscaled[-2]
extendlength = self._get_extension_lengths(
self.extendfrac, automin, automax, default=0.05)
return y, extendlength
Expand Down
9 changes: 9 additions & 0 deletions lib/matplotlib/tests/test_colorbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,15 @@ def test_contour_colorbar():
fig.colorbar(CS, orientation='vertical')


def test_contour_uniformfield_colorbar():
# Smoke test for gh#23817
fig, ax = plt.subplots()
with pytest.warns(Warning) as record:
cs = ax.contour([[1, 1], [1, 1]])
assert len(record) == 1
fig.colorbar(cs, ax=ax)


@image_comparison(['cbar_with_subplots_adjust.png'], remove_text=True,
savefig_kwarg={'dpi': 40})
def test_gridspec_make_colorbar():
Expand Down