-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
adds rcParam axes.formatter.useoffset
#2401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The build errors look un-related to this (and related to the six conversion or locale issues). |
Controls the default value of `useOffset` in `ScalarFormatter`. If | ||
`True` and the data range is much smaller than the data average, then | ||
an offset will be determined such that the tick labels are | ||
meaningful.than small ranges on top of a large absolute value will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah. I was starting to re-write the documentation, but then decided to just use the text from ScalarForamatter
and managed to not delete my version. Fixed now.
One of these days I will get a PR through without documentation issues.... I thought the values shown in the template were supposed to be the default value. In terms of major changes, I think it would be better to move the comment strings to |
This doesn't automatically merge, would you mind rebasing. I'd also like to see a test. Something as simple as mocking ScalarFormatter (untested):
|
rebased, the conflicts were in api_changes. I will try to get to the tests this weekend. I know nothing about mock so I suspect it will take me a while to sort out how that works. |
Is this test sufficient? |
Yes indeed. 👍 Could you add 'mock' to the test dependencies (at https://github.com/matplotlib/matplotlib/blob/master/setupext.py#L651) and squash your commits, and I'll merge. |
I am confused by adding |
@pelson Can you take another look at this? |
@pelson Sorry to be a pest. Is there anything else that needs to be done on this? |
Addresses issue matplotlib#2400 added test for axes.formatter.useoffset rcparam
rebased again |
adds rcParam `axes.formatter.useoffset`
Hi. What about datetime formatter offset? |
@talhum would you consider opening a new feature request for this? |
Addresses issue #2400