-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
README.rst to README.md #24067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.rst to README.md #24067
Conversation
Thanks for doing this. However, most of our documentation is in rst. I would expect we want to continue doing that. |
There are arguments for switching. I’m +0.5 on this. I think this needs a discussion. I don’t have time right now, but want to make sure this is not discarded right away. |
Relevance: I assume this page is mainly viewed through the GitHub interface, in which case, both versions are are rendered and it does not make a difference. Markdown vs. reStructuredText only affects
Overall, it does not matter too much, but given all arguments I'm +0.5 for switching to MD. |
Also at PyPI because it's now the long description, but according to their docs both versions should work https://packaging.python.org/en/latest/guides/making-a-pypi-friendly-readme/ I find the .md slightly easier to work w/, especially through the github interface where I usually do the readme editing, so I'm also +.5, which is I think it's a good idea but won't put up a fight if someone is strongly against. |
README.md
Outdated
used in Python scripts, Python/IPython shells, web application servers, | ||
and various graphical user interface toolkits. | ||
|
||
## **Install** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## **Install** | |
## Install |
I don't think we want bold formatting on top of the heading. Also applies to all following headings.
README.md
Outdated
|
||
## **Contribute** | ||
|
||
You\'ve discovered a bug or something else you want to change - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You\'ve discovered a bug or something else you want to change - | |
You've discovered a bug or something else you want to change - |
Escaping not needed in Markdown.
README.md
Outdated
You\'ve discovered a bug or something else you want to change - | ||
excellent! | ||
|
||
You\'ve worked out a way to fix it -- even better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You\'ve worked out a way to fix it -- even better! | |
You've worked out a way to fix it -- even better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR can't go in w/o
Lines 274 to 275 in 1b3019d
long_description=Path("README.rst").read_text(encoding="utf-8"), | |
long_description_content_type="text/x-rst", |
README.rst
pre-commit.ci autofix |
I'm -1 on this simply because if it isn't broke I don't see why we would go through the thrash of changing it. As you have found, there are places that link this as README.rst and keeping both doesn't seem an option. For better or worse, our docs are in rst. We don't particularly want new contributors adding to our README, so I don't see a strong case for change. |
I'm neutral on this. I agree with basically everything Tim and Jody have said. Changing from rst -> md is basically a wash technically and is mostly an aesthetic preference but has a cost / risk to change (and may have downstream cost if packagers are looking for this file (but I do not know for a fact one way or the other)). That said, the winds of change seem to be blowing in favor of md over rst and it may not be worth the effort to resist. It looks like most of the work seem to be done so there is no sense in throwing it away. I suspect that if we do not take this PR we will get duplicate issues/PRs yearly indefinitely. @grgkaran03 You provoked a discussion among the maintainers (we are not a monolith!). Please be assured that we appreciate your work no matter which way we go on this. I think this does get all of our internal usage:
|
@timhoffm, please review the corrections also is there any changes to be done before members can come to a decision? |
How'd the twine check go? out of scope for this PR, but should we add it to our tests somehow to catch changes to readme? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, this is good. Thanks @grgkaran03!
Let's put it on the agenda of the dev call, whether we want to switch to Markdown.
for the Python Packaging User Guide:
(github can render 9 markup formats) |
The requested changes has been made.
After discussion on the call we have opted to take this. We may have closed #24064 with no action, however this PR got done so we will take it. This is not an endorsement of moving any other part of our documentation to md/myst. |
Thank you for your work on this @grgkaran03 and congratulations on your first merged Matplollib PR 🎉 Hopefully we will hear from you again! |
PR Summary
Change README.rst to README.md. Addressing the issue #24064
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).