Skip to content

Revert argument checking for label_mode #24084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2022
Merged

Revert argument checking for label_mode #24084

merged 1 commit into from
Oct 3, 2022

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Oct 3, 2022

PR Summary

Related to #24053

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus added this to the v3.6.1 milestone Oct 3, 2022
@oscargus oscargus marked this pull request as ready for review October 3, 2022 17:55
@dopplershift dopplershift mentioned this pull request Oct 3, 2022
Closed
@jklymak jklymak merged commit 0517187 into matplotlib:main Oct 3, 2022
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 3, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 3, 2022
@jklymak @meeseeksmachine
Backport PR matplotlib#24084: Revert argument checking for label_mode
8e840d7
QuLogic added a commit that referenced this pull request Oct 3, 2022
@QuLogic
Merge pull request #24087 from meeseeksmachine/auto-backport-of-pr-24…
3748ad5 
…084-on-v3.6.x

Backport PR #24084 on branch v3.6.x (Revert argument checking for label_mode)
@oscargus oscargus deleted the labelbase36 branch October 4, 2022 06:15
@ksunden ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: mpl_toolkit
Projects
None yet
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@oscargus @tacaswell @jklymak