Skip to content

Expire miscellaneous deprecations from 3.5 #24125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Oct 8, 2022

PR Summary

These are not handled from the list in https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.5.0.html#miscellaneous-deprecations

- ``Collection.__init__`` previously ignored *transOffset* without *offsets* also
  being specified. In the future, *transOffset* will begin having an effect
  regardless of *offsets*. In the meantime, if you wish to set *transOffset*,
  call `.Collection.set_offset_transform` explicitly.

I do not follow.

- ``dviread.PsfontsMap`` now raises LookupError instead of KeyError for missing
  fonts.

Should not have been in deprecation?

- ``axisartist.clip_path`` is deprecated with no replacement.

Cannot find it.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus force-pushed the misc35removals branch 3 times, most recently from d472062 to 87f9380 Compare October 8, 2022 11:36
@oscargus oscargus changed the title Remove miscellaneous deprecations from 3.5 Expire miscellaneous deprecations from 3.5 Oct 8, 2022
@oscargus oscargus marked this pull request as ready for review October 8, 2022 12:40
@oscargus oscargus added this to the v3.7.0 milestone Oct 8, 2022
@QuLogic
Copy link
Member

QuLogic commented Oct 13, 2022

These are not handled from the list in https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.5.0.html#miscellaneous-deprecations

- ``Collection.__init__`` previously ignored *transOffset* without *offsets* also
  being specified. In the future, *transOffset* will begin having an effect
  regardless of *offsets*. In the meantime, if you wish to set *transOffset*,
  call `.Collection.set_offset_transform` explicitly.

I do not follow.

That is #21550; it was never put into 3.6 or further.

- ``axisartist.clip_path`` is deprecated with no replacement.

Cannot find it.

It's lib/mpl_toolkits/axisartist/clip_path.py

@oscargus
Copy link
Member Author

Thanks! Sorted!

@oscargus oscargus force-pushed the misc35removals branch 3 times, most recently from 2714689 to 6b1dc5c Compare October 15, 2022 13:56
@oscargus
Copy link
Member Author

I think I may have messed up something when working on different computers. I am pretty sure that more than 1000 lines were removed earlier. But I have double-checked the comments and fixed those things again...

@timhoffm timhoffm merged commit 705d250 into matplotlib:main Oct 30, 2022
@oscargus oscargus deleted the misc35removals branch October 31, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants