Skip to content

Set figure options dynamically #24141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 21, 2022
Merged

Set figure options dynamically #24141

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fc91e61
Set figure options dynamically
chahak13 Oct 11, 2022
0f7b472
Reduce getattr calls and use axis_map dictionary
chahak13 Oct 12, 2022
7e5029e
Change variable names to match coding style
chahak13 Oct 12, 2022
a505dee
Add some changes for variable names
chahak13 Oct 13, 2022
6e21419
Save converter before any changes and reset
chahak13 Oct 14, 2022
9b0fd09
Move related unit and converter code together
chahak13 Oct 20, 2022
53b65e4
Update lib/matplotlib/backends/qt_editor/figureoptions.py
chahak13 Oct 20, 2022
372a837
Update lib/matplotlib/backends/qt_editor/figureoptions.py
chahak13 Oct 20, 2022
3fc1080
Remove redundant `_update_axisinfo` call
chahak13 Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 59 additions & 48 deletions lib/matplotlib/backends/qt_editor/figureoptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

"""Module that provides a GUI-based editor for Matplotlib's figure options."""

from itertools import chain
from matplotlib import cbook, cm, colors as mcolors, markers, image as mimage
from matplotlib.backends.qt_compat import QtGui
from matplotlib.backends.qt_editor import _formlayout
Expand Down Expand Up @@ -38,30 +39,40 @@ def convert_limits(lim, converter):
# Cast to builtin floats as they have nicer reprs.
return map(float, lim)

xconverter = axes.xaxis.converter
xmin, xmax = convert_limits(axes.get_xlim(), xconverter)
yconverter = axes.yaxis.converter
ymin, ymax = convert_limits(axes.get_ylim(), yconverter)
general = [('Title', axes.get_title()),
sep,
(None, "<b>X-Axis</b>"),
('Left', xmin), ('Right', xmax),
('Label', axes.get_xlabel()),
('Scale', [axes.get_xscale(),
'linear', 'log', 'symlog', 'logit']),
sep,
(None, "<b>Y-Axis</b>"),
('Bottom', ymin), ('Top', ymax),
('Label', axes.get_ylabel()),
('Scale', [axes.get_yscale(),
'linear', 'log', 'symlog', 'logit']),
sep,
('(Re-)Generate automatic legend', False),
]

# Save the unit data
xunits = axes.xaxis.get_units()
yunits = axes.yaxis.get_units()
axis_map = axes._axis_map
axis_limits = {
name: tuple(convert_limits(
getattr(axes, f'get_{name}lim')(), axis.converter
))
for name, axis in axis_map.items()
}
general = [
('Title', axes.get_title()),
sep,
*chain.from_iterable([
(
(None, f"<b>{name.title()}-Axis</b>"),
('Min', axis_limits[name][0]),
('Max', axis_limits[name][1]),
('Label', axis.get_label().get_text()),
('Scale', [axis.get_scale(),
'linear', 'log', 'symlog', 'logit']),
sep,
)
for name, axis in axis_map.items()
]),
('(Re-)Generate automatic legend', False),
]

# Save the converter and unit data
axis_converter = {
name: axis.converter
for name, axis in axis_map.items()
}
axis_units = {
name: axis.get_units()
for name, axis in axis_map.items()
}

# Get / Curves
labeled_lines = []
Expand Down Expand Up @@ -165,37 +176,35 @@ def prepare_data(d, init):

def apply_callback(data):
"""A callback to apply changes."""
orig_xlim = axes.get_xlim()
orig_ylim = axes.get_ylim()
orig_limits = {
name: getattr(axes, f"get_{name}lim")()
for name in axis_map
}

general = data.pop(0)
curves = data.pop(0) if has_curve else []
mappables = data.pop(0) if has_sm else []
if data:
raise ValueError("Unexpected field")

# Set / General
(title, xmin, xmax, xlabel, xscale, ymin, ymax, ylabel, yscale,
generate_legend) = general
title = general.pop(0)
axes.set_title(title)
generate_legend = general.pop()

for i, (name, axis) in enumerate(axis_map.items()):
axis_min = general[4*i]
axis_max = general[4*i + 1]
axis_label = general[4*i + 2]
axis_scale = general[4*i + 3]
if axis.get_scale() != axis_scale:
getattr(axes, f"set_{name}scale")(axis_scale)

if axes.get_xscale() != xscale:
axes.set_xscale(xscale)
if axes.get_yscale() != yscale:
axes.set_yscale(yscale)
axis._set_lim(axis_min, axis_max, auto=False)
axis.set_label_text(axis_label)

axes.set_title(title)
axes.set_xlim(xmin, xmax)
axes.set_xlabel(xlabel)
axes.set_ylim(ymin, ymax)
axes.set_ylabel(ylabel)

# Restore the unit data
axes.xaxis.converter = xconverter
axes.yaxis.converter = yconverter
axes.xaxis.set_units(xunits)
axes.yaxis.set_units(yunits)
axes.xaxis._update_axisinfo()
axes.yaxis._update_axisinfo()
# Restore the unit data
axis.converter = axis_converter[name]
axis.set_units(axis_units[name])

# Set / Curves
for index, curve in enumerate(curves):
Expand Down Expand Up @@ -242,8 +251,10 @@ def apply_callback(data):
# Redraw
figure = axes.get_figure()
figure.canvas.draw()
if not (axes.get_xlim() == orig_xlim and axes.get_ylim() == orig_ylim):
figure.canvas.toolbar.push_current()
for name in axis_map:
if getattr(axes, f"get_{name}lim")() != orig_limits[name]:
figure.canvas.toolbar.push_current()
break

_formlayout.fedit(
datalist, title="Figure options", parent=parent,
Expand Down